Change in libosmocore[master]: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 25 10:55:43 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16189 )

Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*()
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/16189/3/src/gsm/gsup.c 
File src/gsm/gsup.c:

https://gerrit.osmocom.org/c/libosmocore/+/16189/3/src/gsm/gsup.c@985 
PS3, Line 985: osmo_gsup_message_name_buf
I think the naming is wrong.  This function is not just putting the message name into a buffer (which is what we have value_str for anyway), but it's actually giving a stringified version of the message.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16189
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id9692880079ea0f219f52d81b1923a76fc640566
Gerrit-Change-Number: 16189
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 25 Nov 2019 10:55:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191125/21511f8d/attachment.htm>


More information about the gerrit-log mailing list