Change in libosmocore[master]: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Sun Nov 24 21:24:26 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16189 )

Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*()
......................................................................


Patch Set 3:

I almost added osmo_gsup_make_response() in osmo-hlr instead.

On the one hand, all GSUP users I know use libosmo-gsupclient, which is implemented in osmo-hlr.git. It makes sense to avoid spreading GSUP implementations across several repositories.

On the other hand, osmo-hlr.git has no gsup.c file, and no implementation with semantics as close to the individual IEs as libosmocore's gsup.c. Whether an IE is absolutely required in a response message is a pretty low level decision.

So in the end, I placed it here. But it's not a very strong opinion of mine.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16189
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id9692880079ea0f219f52d81b1923a76fc640566
Gerrit-Change-Number: 16189
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Sun, 24 Nov 2019 21:24:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191124/3fd5829c/attachment.htm>


More information about the gerrit-log mailing list