Change in libosmocore[master]: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14864 )

Change subject: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE
......................................................................


Patch Set 3:

(2 comments)

Please explain better why you are changing the behavior.

https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h 
File include/osmocom/core/defs.h:

https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h@46 
PS3, Line 46: # define OSMO_DEPRECATED_OUTSIDE(text)
It's more clear if you keep and extend older name:
OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE_TXT(text)


https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/gsm/gsm48_ie.h 
File include/osmocom/gsm/gsm48_ie.h:

https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/gsm/gsm48_ie.h@18 
PS3, Line 18: 	OSMO_DEPRECATED_OUTSIDE("Use gsm48_decode_bcd_number2() for improved bounds checking");
Why shouldn't libosmocore use gsm48_decode_bcd_number2?

In some specific cases, it may make more sense to disable the relative pragma for deprecation and enable it afterwards after using the function. I'm pretty sure that can be done and is far more clear.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14864
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1b0eff1396776900c1286e41da3aee3ff78b326e
Gerrit-Change-Number: 14864
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Nov 2019 19:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191108/e20d5dd3/attachment.htm>