<p style="white-space: pre-wrap; word-wrap: break-word;">Please explain better why you are changing the behavior.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14864">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h">File include/osmocom/core/defs.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h@46">Patch Set #3, Line 46:</a> <code style="font-family:monospace,monospace"># define OSMO_DEPRECATED_OUTSIDE(text)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It's more clear if you keep and extend older name:<br>OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE_TXT(text)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/gsm/gsm48_ie.h">File include/osmocom/gsm/gsm48_ie.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/gsm/gsm48_ie.h@18">Patch Set #3, Line 18:</a> <code style="font-family:monospace,monospace">       OSMO_DEPRECATED_OUTSIDE("Use gsm48_decode_bcd_number2() for improved bounds checking");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why shouldn't libosmocore use gsm48_decode_bcd_number2?</p><p style="white-space: pre-wrap; word-wrap: break-word;">In some specific cases, it may make more sense to disable the relative pragma for deprecation and enable it afterwards after using the function. I'm pretty sure that can be done and is far more clear.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14864">change 14864</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14864"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1b0eff1396776900c1286e41da3aee3ff78b326e </div>
<div style="display:none"> Gerrit-Change-Number: 14864 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 08 Nov 2019 19:09:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>