Change in osmo-pcu[master]: BSSGP: do not reject SUSPEND ACK / NACK messages

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16006 )

Change subject: BSSGP: do not reject SUSPEND ACK / NACK messages
......................................................................

BSSGP: do not reject SUSPEND ACK / NACK messages

Both BSSGP SUSPEND ACK and NACK messages use BVCI=0 (signaling),
which always exists. Claiming that BVCI=0 is unknown is wrong.

Instead of adding both BSSGP_PDUT_SUSPEND_{ACK,NACK} to the 'if'
statement, let's rather avoid rejection for all BVCI=0 messages,
as there may be other unlisted message types.

Change-Id: I780657c1e8f67e0bef0e92a31db7ba61b57d7ec4
Related: OS#4111
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index abcb106..f99058a 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -407,10 +407,7 @@
 	/* look-up or create the BTS context for this BVC */
 	bctx = btsctx_by_bvci_nsei(ns_bvci, msgb_nsei(msg));
 
-	if (!bctx
-	 && pdu_type != BSSGP_PDUT_BVC_RESET_ACK
-	 && pdu_type != BSSGP_PDUT_BVC_UNBLOCK_ACK
-	 && pdu_type != BSSGP_PDUT_PAGING_PS)
+	if (!bctx && ns_bvci != BVCI_SIGNALLING)
 	{
 		LOGP(DBSSGP, LOGL_NOTICE, "NSEI=%u/BVCI=%u Rejecting PDU type %s for unknown BVCI\n",
 		     nsei, ns_bvci, bssgp_pdu_str(pdu_type));

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16006
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I780657c1e8f67e0bef0e92a31db7ba61b57d7ec4
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191108/353eb9c5/attachment.htm>