<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16006">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSSGP: do not reject SUSPEND ACK / NACK messages<br><br>Both BSSGP SUSPEND ACK and NACK messages use BVCI=0 (signaling),<br>which always exists. Claiming that BVCI=0 is unknown is wrong.<br><br>Instead of adding both BSSGP_PDUT_SUSPEND_{ACK,NACK} to the 'if'<br>statement, let's rather avoid rejection for all BVCI=0 messages,<br>as there may be other unlisted message types.<br><br>Change-Id: I780657c1e8f67e0bef0e92a31db7ba61b57d7ec4<br>Related: OS#4111<br>---<br>M src/gprs_bssgp_pcu.cpp<br>1 file changed, 1 insertion(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp</span><br><span>index abcb106..f99058a 100644</span><br><span>--- a/src/gprs_bssgp_pcu.cpp</span><br><span>+++ b/src/gprs_bssgp_pcu.cpp</span><br><span>@@ -407,10 +407,7 @@</span><br><span>  /* look-up or create the BTS context for this BVC */</span><br><span>         bctx = btsctx_by_bvci_nsei(ns_bvci, msgb_nsei(msg));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        if (!bctx</span><br><span style="color: hsl(0, 100%, 40%);">-        && pdu_type != BSSGP_PDUT_BVC_RESET_ACK</span><br><span style="color: hsl(0, 100%, 40%);">-         && pdu_type != BSSGP_PDUT_BVC_UNBLOCK_ACK</span><br><span style="color: hsl(0, 100%, 40%);">-       && pdu_type != BSSGP_PDUT_PAGING_PS)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!bctx && ns_bvci != BVCI_SIGNALLING)</span><br><span>     {</span><br><span>            LOGP(DBSSGP, LOGL_NOTICE, "NSEI=%u/BVCI=%u Rejecting PDU type %s for unknown BVCI\n",</span><br><span>                   nsei, ns_bvci, bssgp_pdu_str(pdu_type));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16006">change 16006</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/16006"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I780657c1e8f67e0bef0e92a31db7ba61b57d7ec4 </div>
<div style="display:none"> Gerrit-Change-Number: 16006 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>