Change in osmo-pcu[master]: GprsMs::update_cs_ul(): clarify the meaning of old_link_qual

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16009 )


Change subject: GprsMs::update_cs_ul(): clarify the meaning of old_link_qual
......................................................................

GprsMs::update_cs_ul(): clarify the meaning of old_link_qual

Change-Id: Iad703a573621c64613b9b8c229079dc63fcaeb9e
---
M src/gprs_ms.cpp
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/09/16009/1

diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp
index 5b35e65..d271bc4 100644
--- a/src/gprs_ms.cpp
+++ b/src/gprs_ms.cpp
@@ -648,8 +648,6 @@
 		return;
 	}
 
-	old_link_qual = meas->link_qual;
-
 	if (mcs_is_gprs(m_current_cs_ul)) {
 		if (current_cs >= MAX_GPRS_CS)
 			current_cs = MAX_GPRS_CS - 1;
@@ -667,8 +665,12 @@
 		return;
 	}
 
+	/* To avoid rapid changes of the coding scheme, we also take
+	 * the old link quality value into account (if present). */
 	if (m_l1_meas.have_link_qual)
 		old_link_qual = m_l1_meas.link_qual;
+	else
+		old_link_qual = meas->link_qual;
 
 	if (meas->link_qual < low &&  old_link_qual < low)
 		new_cs_ul.dec(mode());

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16009
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iad703a573621c64613b9b8c229079dc63fcaeb9e
Gerrit-Change-Number: 16009
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191107/88393be4/attachment.htm>