<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16009">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">GprsMs::update_cs_ul(): clarify the meaning of old_link_qual<br><br>Change-Id: Iad703a573621c64613b9b8c229079dc63fcaeb9e<br>---<br>M src/gprs_ms.cpp<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/09/16009/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp</span><br><span>index 5b35e65..d271bc4 100644</span><br><span>--- a/src/gprs_ms.cpp</span><br><span>+++ b/src/gprs_ms.cpp</span><br><span>@@ -648,8 +648,6 @@</span><br><span>              return;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   old_link_qual = meas->link_qual;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  if (mcs_is_gprs(m_current_cs_ul)) {</span><br><span>          if (current_cs >= MAX_GPRS_CS)</span><br><span>                    current_cs = MAX_GPRS_CS - 1;</span><br><span>@@ -667,8 +665,12 @@</span><br><span>                 return;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* To avoid rapid changes of the coding scheme, we also take</span><br><span style="color: hsl(120, 100%, 40%);">+   * the old link quality value into account (if present). */</span><br><span>  if (m_l1_meas.have_link_qual)</span><br><span>                old_link_qual = m_l1_meas.link_qual;</span><br><span style="color: hsl(120, 100%, 40%);">+  else</span><br><span style="color: hsl(120, 100%, 40%);">+          old_link_qual = meas->link_qual;</span><br><span> </span><br><span>      if (meas->link_qual < low &&  old_link_qual < low)</span><br><span>          new_cs_ul.dec(mode());</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16009">change 16009</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/16009"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iad703a573621c64613b9b8c229079dc63fcaeb9e </div>
<div style="display:none"> Gerrit-Change-Number: 16009 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>