Change in osmo-bts[master]: rsl: Assign recv pwr to lchan's max ms power

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15970 )


Change subject: rsl: Assign recv pwr to lchan's max ms power
......................................................................

rsl: Assign recv pwr to lchan's max ms power

Otherwise older ms_power value will be kept and used as a maximum.

>From TS 08.58 sec 4.8 "MS power control":
"""
If  power  control  is  supported  by  BTS  and  it  is  to  be  used,
this  is  indicated  by  optional  parameters  in  theMS   POWER   CONTROL
message   (or   the   CHANNEL   ACTIVATION   message).   Based   on   the
measurements  performed  on  the  uplink,  TRX  then  attempts  to  keep
the  power  control  parameters  within  the  limits  set  by  the
MS  POWER  CONTROL  message  (or  by  the  CHANNEL  ACTIVATION  message).
"""

Change-Id: I0583eef477c33279ee5bfcda80141f365413a276
---
M src/common/rsl.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/70/15970/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index de51e6f..3358976 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1633,7 +1633,10 @@
 		return rsl_tx_error_report(msg->trx, RSL_ERR_MAND_IE_ERROR, &dch->chan_nr, NULL, msg);
 
 	pwr = *TLVP_VAL(&tp, RSL_IE_MS_POWER) & 0x1F;
-	lchan->ms_power_ctrl.current = pwr;
+	lchan->ms_power = pwr;
+	/* FIXME: only set current to lchan->ms_power if actual value of current
+	   in dBm > value in dBm from lchan->ms_power, or if fixed=1. */
+	lchan->ms_power_ctrl.current = lchan->ms_power;
 
 	LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "Rx MS POWER CONTROL %d\n", lchan->ms_power_ctrl.current);
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15970
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0583eef477c33279ee5bfcda80141f365413a276
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191105/c9ab06f0/attachment.htm>