<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/15970">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rsl: Assign recv pwr to lchan's max ms power<br><br>Otherwise older ms_power value will be kept and used as a maximum.<br><br>From TS 08.58 sec 4.8 "MS power control":<br>"""<br>If power control is supported by BTS and it is to be used,<br>this is indicated by optional parameters in theMS POWER CONTROL<br>message (or the CHANNEL ACTIVATION message). Based on the<br>measurements performed on the uplink, TRX then attempts to keep<br>the power control parameters within the limits set by the<br>MS POWER CONTROL message (or by the CHANNEL ACTIVATION message).<br>"""<br><br>Change-Id: I0583eef477c33279ee5bfcda80141f365413a276<br>---<br>M src/common/rsl.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/70/15970/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index de51e6f..3358976 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1633,7 +1633,10 @@</span><br><span> return rsl_tx_error_report(msg->trx, RSL_ERR_MAND_IE_ERROR, &dch->chan_nr, NULL, msg);</span><br><span> </span><br><span> pwr = *TLVP_VAL(&tp, RSL_IE_MS_POWER) & 0x1F;</span><br><span style="color: hsl(0, 100%, 40%);">- lchan->ms_power_ctrl.current = pwr;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->ms_power = pwr;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: only set current to lchan->ms_power if actual value of current</span><br><span style="color: hsl(120, 100%, 40%);">+ in dBm > value in dBm from lchan->ms_power, or if fixed=1. */</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->ms_power_ctrl.current = lchan->ms_power;</span><br><span> </span><br><span> LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "Rx MS POWER CONTROL %d\n", lchan->ms_power_ctrl.current);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/15970">change 15970</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/15970"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0583eef477c33279ee5bfcda80141f365413a276 </div>
<div style="display:none"> Gerrit-Change-Number: 15970 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>