Change in osmo-ttcn3-hacks[master]: bsc: Verify presence of MS Power Parameters IE on one test

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15966 )


Change subject: bsc: Verify presence of MS Power Parameters IE on one test
......................................................................

bsc: Verify presence of MS Power Parameters IE on one test

Otherwise most tests in bsc-latest fail because in latest release BSC
never sends that IE.

Related: OS#4244
Change-Id: I725836784a7900d2ea51eae188c2c279e8639dbf
---
M bsc/BSC_Tests.ttcn
M bsc/MSC_ConnectionHandler.ttcn
M bsc/expected-results.xml
3 files changed, 19 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/15966/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index e7a4c13..9c8d68d 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -4372,6 +4372,19 @@
 	}
 }
 
+/* Verify the BSC sends the MS Power Parameters IE during CHAN ACT to make sure
+   the BTS does autonomous MS power control loop */
+testcase TC_assignment_verify_ms_power_params_ie() runs on test_CT {
+	var MSC_ConnHdlr vc_conn;
+	var TestHdlrParams pars := f_gen_test_hdlr_pars();
+	//pars.encr := valueof(t_EncrParams('01'O, f_rnd_octstring(8)));
+	pars.exp_ms_power_params := true;
+
+	f_init(1, true);
+	f_sleep(1.0);
+	vc_conn := f_start_handler(refers(f_tc_assignment_fr_a5), pars);
+	vc_conn.done;
+}
 
 /* Dyn PDCH todo:
    * activate OSMO as TCH/F
@@ -4541,6 +4554,8 @@
 	execute( TC_chopped_ipa_ping() );
 	execute( TC_chopped_ipa_payload() );
 
+	/* Power control related */
+	execute( TC_assignment_verify_ms_power_params_ie() );
 	/* at bottom as they might crash OsmoBSC before OS#3182 is fixed */
 	execute( TC_early_conn_fail() );
 	execute( TC_late_conn_fail() );
diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 09190e3..0141522 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -527,6 +527,7 @@
 	TestHdlrParamsLcls lcls,
 	TestHdlrParamsHandover handover optional,
 	uint5_t 	exp_ms_power_level,
+	boolean         exp_ms_power_params,
 	boolean		aoip,
 	boolean		use_osmux
 };
@@ -553,6 +554,7 @@
 	},
 	handover := omit,
 	exp_ms_power_level := 7, /* calculated from osmo-bsc.cfg "ms max power" */
+	exp_ms_power_params := false,
 	aoip := true,
 	use_osmux := false
 }
@@ -762,7 +764,7 @@
 	/* FIXME: validate RSL_IE_ACT_TYPE, RSL_IE_CHAN_MODE, RSL_IE_CHAN_IDENT, RSL_IE_BS_POWER,
 	 * RSL_IE_TIMING_ADVANCE */
 
-	if (not f_rsl_find_ie(chan_act, RSL_IE_MS_POWER_PARAM, ms_power_param)) {
+	if (g_pars.exp_ms_power_params and not f_rsl_find_ie(chan_act, RSL_IE_MS_POWER_PARAM, ms_power_param)) {
 		Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "IE MS Power Parameters not found in CHAN ACT");
 	}
 
diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml
index 3ea202c..eb932ef 100644
--- a/bsc/expected-results.xml
+++ b/bsc/expected-results.xml
@@ -102,6 +102,7 @@
   <testcase classname='BSC_Tests' name='TC_dyn_pdch_osmo_act_nack' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_chopped_ipa_ping' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_chopped_ipa_payload' time='MASKED'/>
+  <testcase classname='BSC_Tests' name='TC_assignment_verify_ms_power_params_ie' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_early_conn_fail' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_late_conn_fail' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_assignment_codec_amr_f_S1' time='MASKED'/>

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15966
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I725836784a7900d2ea51eae188c2c279e8639dbf
Gerrit-Change-Number: 15966
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191105/fbcc94c7/attachment.htm>