<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15966">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Verify presence of MS Power Parameters IE on one test<br><br>Otherwise most tests in bsc-latest fail because in latest release BSC<br>never sends that IE.<br><br>Related: OS#4244<br>Change-Id: I725836784a7900d2ea51eae188c2c279e8639dbf<br>---<br>M bsc/BSC_Tests.ttcn<br>M bsc/MSC_ConnectionHandler.ttcn<br>M bsc/expected-results.xml<br>3 files changed, 19 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/15966/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index e7a4c13..9c8d68d 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -4372,6 +4372,19 @@</span><br><span>       }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify the BSC sends the MS Power Parameters IE during CHAN ACT to make sure</span><br><span style="color: hsl(120, 100%, 40%);">+   the BTS does autonomous MS power control loop */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_assignment_verify_ms_power_params_ie() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+        var MSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+     var TestHdlrParams pars := f_gen_test_hdlr_pars();</span><br><span style="color: hsl(120, 100%, 40%);">+    //pars.encr := valueof(t_EncrParams('01'O, f_rnd_octstring(8)));</span><br><span style="color: hsl(120, 100%, 40%);">+      pars.exp_ms_power_params := true;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   f_init(1, true);</span><br><span style="color: hsl(120, 100%, 40%);">+      f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_tc_assignment_fr_a5), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+      vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> /* Dyn PDCH todo:</span><br><span>    * activate OSMO as TCH/F</span><br><span>@@ -4541,6 +4554,8 @@</span><br><span>     execute( TC_chopped_ipa_ping() );</span><br><span>    execute( TC_chopped_ipa_payload() );</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      /* Power control related */</span><br><span style="color: hsl(120, 100%, 40%);">+   execute( TC_assignment_verify_ms_power_params_ie() );</span><br><span>        /* at bottom as they might crash OsmoBSC before OS#3182 is fixed */</span><br><span>  execute( TC_early_conn_fail() );</span><br><span>     execute( TC_late_conn_fail() );</span><br><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index 09190e3..0141522 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -527,6 +527,7 @@</span><br><span>   TestHdlrParamsLcls lcls,</span><br><span>     TestHdlrParamsHandover handover optional,</span><br><span>    uint5_t         exp_ms_power_level,</span><br><span style="color: hsl(120, 100%, 40%);">+   boolean         exp_ms_power_params,</span><br><span>         boolean         aoip,</span><br><span>        boolean         use_osmux</span><br><span> };</span><br><span>@@ -553,6 +554,7 @@</span><br><span>        },</span><br><span>   handover := omit,</span><br><span>    exp_ms_power_level := 7, /* calculated from osmo-bsc.cfg "ms max power" */</span><br><span style="color: hsl(120, 100%, 40%);">+  exp_ms_power_params := false,</span><br><span>        aoip := true,</span><br><span>        use_osmux := false</span><br><span> }</span><br><span>@@ -762,7 +764,7 @@</span><br><span>        /* FIXME: validate RSL_IE_ACT_TYPE, RSL_IE_CHAN_MODE, RSL_IE_CHAN_IDENT, RSL_IE_BS_POWER,</span><br><span>     * RSL_IE_TIMING_ADVANCE */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (not f_rsl_find_ie(chan_act, RSL_IE_MS_POWER_PARAM, ms_power_param)) {</span><br><span style="color: hsl(120, 100%, 40%);">+     if (g_pars.exp_ms_power_params and not f_rsl_find_ie(chan_act, RSL_IE_MS_POWER_PARAM, ms_power_param)) {</span><br><span>             Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "IE MS Power Parameters not found in CHAN ACT");</span><br><span>        }</span><br><span> </span><br><span>diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml</span><br><span>index 3ea202c..eb932ef 100644</span><br><span>--- a/bsc/expected-results.xml</span><br><span>+++ b/bsc/expected-results.xml</span><br><span>@@ -102,6 +102,7 @@</span><br><span>   <testcase classname='BSC_Tests' name='TC_dyn_pdch_osmo_act_nack' time='MASKED'/></span><br><span>   <testcase classname='BSC_Tests' name='TC_chopped_ipa_ping' time='MASKED'/></span><br><span>   <testcase classname='BSC_Tests' name='TC_chopped_ipa_payload' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+  <testcase classname='BSC_Tests' name='TC_assignment_verify_ms_power_params_ie' time='MASKED'/></span><br><span>   <testcase classname='BSC_Tests' name='TC_early_conn_fail' time='MASKED'/></span><br><span>   <testcase classname='BSC_Tests' name='TC_late_conn_fail' time='MASKED'/></span><br><span>   <testcase classname='BSC_Tests' name='TC_assignment_codec_amr_f_S1' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15966">change 15966</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15966"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I725836784a7900d2ea51eae188c2c279e8639dbf </div>
<div style="display:none"> Gerrit-Change-Number: 15966 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>