Change in osmo-bsc[master]: RSL: Wrong CCCH_CONFIG in SI3 causes a lot of MO call setup failed wh...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Nov 1 16:13:49 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15909 )

Change subject: RSL: Wrong CCCH_CONFIG in SI3 causes a lot of MO call setup failed when the BTS configured with none combined CCCH mode.
......................................................................


Patch Set 1: Code-Review-2

(1 comment)

Adding Neels as he is the (most likely) author of the related code.

https://gerrit.osmocom.org/c/osmo-bsc/+/15909/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/15909/1/src/osmo-bsc/bsc_vty.c@4341 
PS1, Line 4341: pchan_is
Furthermore, as far as I can see from include/osmocom/bsc/gsm_data.h:

  - pchan_from_config - channel configuration from the configuration file (can be changed from the VTY at runtime, should not affect the existing RSL/OML connections);
  - pchan_on_init - channel configuration after the OML link is established (pchan_from_config is copied here);
  - pchan_is - the *actual* channel configuration currently active.

The question is why pchan_is does not reflect the _actual_ channel configuration? I think the problem is somewhere deeper in the code (src/osmo-bsc/timeslot_fsm.c?). And most likely this patch is not the right solution, because we shall not change the actual channel configuration from the VTY. Sorry.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15909
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I33ea7808ac1bd064b88fd609bd7dfe0c8aa341f2
Gerrit-Change-Number: 15909
Gerrit-PatchSet: 1
Gerrit-Owner: mqng2 <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: mqng2 <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Nov 2019 16:13:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191101/74314f75/attachment.htm>


More information about the gerrit-log mailing list