This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15909 ) Change subject: RSL: Wrong CCCH_CONFIG in SI3 causes a lot of MO call setup failed when the BTS configured with none combined CCCH mode. ...................................................................... Patch Set 1: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/15909/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/15909/1//COMMIT_MSG@7 PS1, Line 7: Wrong CCCH_CONFIG in SI3 causes a lot of MO call setup failed when the BTS configured with none combined CCCH mode. Please make this line shorter, for example: "RSL: fix: use proper CCCH_CONFIG in SI3 for non-combined CCCH". MO call failures are consequences of the incorrect CCCH_CONFIG value, you already mention that in the message below. https://gerrit.osmocom.org/c/osmo-bsc/+/15909/1//COMMIT_MSG@10 PS1, Line 10: the CCCH is configured in none combined with SDCCH (a dedicated TS is configured for SDCCH) This looks very confusing. I first thought you somehow managed to combine SDCCH with NONE :) I am not a native speaker, but IMHO this would be much cleaner: "... when the network is configured to use non-combined CCCH". https://gerrit.osmocom.org/c/osmo-bsc/+/15909/1//COMMIT_MSG@24 PS1, Line 24: it turns out that the BTS broadcasts wrong CCCH_CONF=1 I confirm that we have a bug in OsmoBSC. Just manually tested with both 'CCCH' and 'CCCH+SDCCH4' channel combinations, and in both cases SI3 contains: 001 = CCCH-CONF: 1 basic physical channel used for CCCH, combined with SDCCHs (1) We need a TTCN-3 test case to reproduce the problem (should be easy to implement). Could you please create a ticket at http://osmocom.org/projects/osmobsc/issues/new ? https://gerrit.osmocom.org/c/osmo-bsc/+/15909/1/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/15909/1/src/osmo-bsc/bsc_vty.c@4304 PS1, Line 4304: cfg_ts_pchan > I fixed at this at first but it did not fix the issue. Fixing in the cfg_ts_pchan_compt solved the problem. Most likely, because you're using the old-style uppercase pchan type names. I think we need to fix both functions. Otherwise the bug will still affect configuration files with the lowercase names. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15909 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I33ea7808ac1bd064b88fd609bd7dfe0c8aa341f2 Gerrit-Change-Number: 15909 Gerrit-PatchSet: 1 Gerrit-Owner: mqng2 <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: mqng2 <minh-quang.nguyen at nutaq.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 01 Nov 2019 16:00:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191101/5f1057f1/attachment.htm>