This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14162 ) Change subject: oml: Have one generic log message for all transmitted messages ...................................................................... oml: Have one generic log message for all transmitted messages Rather than open-coding "Tx foobar..." in various functions (and forgetting it in half of them), let's add a generic message into oml_mo_send_msg(). Change-Id: I5dd4b1749e68fb7fc74cb2e3a778d2418f46b770 --- M src/common/oml.c 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, approved Pau Espin Pedrol: Looks good to me, but someone else must approve diff --git a/src/common/oml.c b/src/common/oml.c index 63643c5..67eb6d8 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -141,6 +141,8 @@ /* FIXME: This assumption may not always be correct */ msg->trx = mo->bts->c0; + DEBUGPFOH(DOML, foh, "Tx %s\n", get_value_string(abis_nm_msgtype_names, foh->msg_type)); + return oml_send_msg(msg, 0); } @@ -277,8 +279,6 @@ const char *mo_name = gsm_abis_mo_name(mo); int rc; - LOGP(DOML, LOGL_INFO, "%s Tx Get Attribute Response\n", mo_name); - if (!nmsg) return -NM_NACK_CANT_PERFORM; @@ -314,8 +314,6 @@ { struct msgb *nmsg; - LOGP(DOML, LOGL_INFO, "%s Tx STATE CHG REP\n", gsm_abis_mo_name(mo)); - nmsg = oml_msgb_alloc(); if (!nmsg) return -ENOMEM; @@ -470,8 +468,6 @@ { struct msgb *nmsg; - LOGP(DOML, LOGL_INFO, "%s Tx SW ACT REP\n", gsm_abis_mo_name(mo)); - nmsg = oml_msgb_alloc(); if (!nmsg) return -ENOMEM; -- To view, visit https://gerrit.osmocom.org/14162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5dd4b1749e68fb7fc74cb2e3a778d2418f46b770 Gerrit-Change-Number: 14162 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190526/916a6be0/attachment.htm>