<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/14162">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">oml: Have one generic log message for all transmitted messages<br><br>Rather than open-coding "Tx foobar..." in various functions (and<br>forgetting it in half of them), let's add a generic message into<br>oml_mo_send_msg().<br><br>Change-Id: I5dd4b1749e68fb7fc74cb2e3a778d2418f46b770<br>---<br>M src/common/oml.c<br>1 file changed, 2 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index 63643c5..67eb6d8 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -141,6 +141,8 @@</span><br><span>         /* FIXME: This assumption may not always be correct */</span><br><span>       msg->trx = mo->bts->c0;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  DEBUGPFOH(DOML, foh, "Tx %s\n", get_value_string(abis_nm_msgtype_names, foh->msg_type));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      return oml_send_msg(msg, 0);</span><br><span> }</span><br><span> </span><br><span>@@ -277,8 +279,6 @@</span><br><span>  const char *mo_name = gsm_abis_mo_name(mo);</span><br><span>  int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     LOGP(DOML, LOGL_INFO, "%s Tx Get Attribute Response\n", mo_name);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  if (!nmsg)</span><br><span>           return -NM_NACK_CANT_PERFORM;</span><br><span> </span><br><span>@@ -314,8 +314,6 @@</span><br><span> {</span><br><span>         struct msgb *nmsg;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  LOGP(DOML, LOGL_INFO, "%s Tx STATE CHG REP\n", gsm_abis_mo_name(mo));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      nmsg = oml_msgb_alloc();</span><br><span>     if (!nmsg)</span><br><span>           return -ENOMEM;</span><br><span>@@ -470,8 +468,6 @@</span><br><span> {</span><br><span>   struct msgb *nmsg;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  LOGP(DOML, LOGL_INFO, "%s Tx SW ACT REP\n", gsm_abis_mo_name(mo));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         nmsg = oml_msgb_alloc();</span><br><span>     if (!nmsg)</span><br><span>           return -ENOMEM;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14162">change 14162</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14162"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I5dd4b1749e68fb7fc74cb2e3a778d2418f46b770 </div>
<div style="display:none"> Gerrit-Change-Number: 14162 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>