Change in osmocom-bb[master]: sap_fsm: Fix what appears to be a missing pointer dereference

[Harald Welte]

Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/14135


Change subject: sap_fsm: Fix what appears to be a missing pointer dereference
......................................................................

sap_fsm: Fix what appears to be a missing pointer dereference

sap_fsm.c: In function ‘sap_negotiate_msg_size’:
sap_fsm.c:103:15: warning: passing argument 1 of ‘__bswap_16’ makes integer from pointer without a cast [-Wint-conversion]
  size = ntohs((uint16_t *) param->value);
               ^~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: Ie58af6162c67ae377809b42daa897ca3f3d72af1
---
M src/host/layer23/src/common/sap_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/35/14135/1

diff --git a/src/host/layer23/src/common/sap_fsm.c b/src/host/layer23/src/common/sap_fsm.c
index f07488f..742e200 100644
--- a/src/host/layer23/src/common/sap_fsm.c
+++ b/src/host/layer23/src/common/sap_fsm.c
@@ -100,7 +100,7 @@
 	}
 
 	/* Parse MaxMsgSize suggested by server */
-	size = ntohs((uint16_t *) param->value);
+	size = ntohs(*(uint16_t *) param->value);
 	if (size > SAP_MAX_MSG_SIZE) {
 		cause = "suggested MaxMsgSize is too big for us";
 		goto error;

-- 
To view, visit https://gerrit.osmocom.org/14135
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie58af6162c67ae377809b42daa897ca3f3d72af1
Gerrit-Change-Number: 14135
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190522/58900b87/attachment.htm>