<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14135">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sap_fsm: Fix what appears to be a missing pointer dereference<br><br>sap_fsm.c: In function ‘sap_negotiate_msg_size’:<br>sap_fsm.c:103:15: warning: passing argument 1 of ‘__bswap_16’ makes integer from pointer without a cast [-Wint-conversion]<br>  size = ntohs((uint16_t *) param->value);<br>               ^~~~~~~~~~~~~~~~~~~~~~~~~<br><br>Change-Id: Ie58af6162c67ae377809b42daa897ca3f3d72af1<br>---<br>M src/host/layer23/src/common/sap_fsm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/35/14135/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/common/sap_fsm.c b/src/host/layer23/src/common/sap_fsm.c</span><br><span>index f07488f..742e200 100644</span><br><span>--- a/src/host/layer23/src/common/sap_fsm.c</span><br><span>+++ b/src/host/layer23/src/common/sap_fsm.c</span><br><span>@@ -100,7 +100,7 @@</span><br><span>      }</span><br><span> </span><br><span>        /* Parse MaxMsgSize suggested by server */</span><br><span style="color: hsl(0, 100%, 40%);">-      size = ntohs((uint16_t *) param->value);</span><br><span style="color: hsl(120, 100%, 40%);">+   size = ntohs(*(uint16_t *) param->value);</span><br><span>         if (size > SAP_MAX_MSG_SIZE) {</span><br><span>            cause = "suggested MaxMsgSize is too big for us";</span><br><span>          goto error;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14135">change 14135</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14135"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie58af6162c67ae377809b42daa897ca3f3d72af1 </div>
<div style="display:none"> Gerrit-Change-Number: 14135 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>