This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/13947 ) Change subject: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Handover tests") ...................................................................... Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Handover tests") Commit 0ac6315212a breaks all related GSUP SS tests because it require all GSUP SS packages to have a OSMO_GSUP_MESSAGE_CLASS_USSD IE. Change-Id: Iadbc37105fa67cf6383fb63b86ed653ccc7bddf7 --- M library/GSUP_Types.ttcn 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified Objections: Neels Hofmeyr: I would prefer this is not merged as is diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn index 73f4562..7e26e19 100644 --- a/library/GSUP_Types.ttcn +++ b/library/GSUP_Types.ttcn @@ -1091,20 +1091,14 @@ tr_GSUP_IE_SessionId(sid), tr_GSUP_IE_SessionState(state) }; - var integer last_idx := 3; /* Optional SS payload */ if (istemplatekind(ss, "*")) { ies[3] := *; - last_idx := last_idx + 1; } else if (not istemplatekind(ss, "omit")) { ies[3] := tr_GSUP_IE_SSInfo(ss); - last_idx := last_idx + 1; } - ies[last_idx] := tr_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_USSD); - last_idx := last_idx + 1; - return ies; } -- To view, visit https://gerrit.osmocom.org/13947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iadbc37105fa67cf6383fb63b86ed653ccc7bddf7 Gerrit-Change-Number: 13947 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/823c4916/attachment.htm>