<p>lynxis lazus <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13947">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

Objections:
  Neels Hofmeyr: I would prefer this is not merged as is

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Handover tests")<br><br>Commit 0ac6315212a breaks all related GSUP SS tests because it require<br>all GSUP SS packages to have a OSMO_GSUP_MESSAGE_CLASS_USSD IE.<br><br>Change-Id: Iadbc37105fa67cf6383fb63b86ed653ccc7bddf7<br>---<br>M library/GSUP_Types.ttcn<br>1 file changed, 0 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn</span><br><span>index 73f4562..7e26e19 100644</span><br><span>--- a/library/GSUP_Types.ttcn</span><br><span>+++ b/library/GSUP_Types.ttcn</span><br><span>@@ -1091,20 +1091,14 @@</span><br><span>                 tr_GSUP_IE_SessionId(sid),</span><br><span>           tr_GSUP_IE_SessionState(state)</span><br><span>       };</span><br><span style="color: hsl(0, 100%, 40%);">-      var integer last_idx := 3;</span><br><span> </span><br><span>       /* Optional SS payload */</span><br><span>    if (istemplatekind(ss, "*")) {</span><br><span>             ies[3] := *;</span><br><span style="color: hsl(0, 100%, 40%);">-            last_idx := last_idx + 1;</span><br><span>    } else if (not istemplatekind(ss, "omit")) {</span><br><span>               ies[3] := tr_GSUP_IE_SSInfo(ss);</span><br><span style="color: hsl(0, 100%, 40%);">-                last_idx := last_idx + 1;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   ies[last_idx] := tr_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_USSD);</span><br><span style="color: hsl(0, 100%, 40%);">-        last_idx := last_idx + 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    return ies;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13947">change 13947</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13947"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iadbc37105fa67cf6383fb63b86ed653ccc7bddf7 </div>
<div style="display:none"> Gerrit-Change-Number: 13947 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>