This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13883 ) Change subject: osmux: Log osmux socket during osmux_init ...................................................................... osmux: Log osmux socket during osmux_init Change-Id: I43a658b19765b1c3b3cc42f78602b793ee36c67d --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Harald Welte: Looks good to me, approved Vadim Yanitskiy: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 7e26d7a..ce89df1 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -15,6 +15,7 @@ #include <inttypes.h> /* for PRIu64 */ #include <netinet/in.h> #include <osmocom/core/msgb.h> +#include <osmocom/core/socket.h> #include <osmocom/core/talloc.h> #include <osmocom/netif/osmux.h> @@ -517,7 +518,8 @@ ret = mgcp_create_bind(cfg->osmux_addr, &osmux_fd, cfg->osmux_port); if (ret < 0) { - LOGP(DLMGCP, LOGL_ERROR, "cannot bind OSMUX socket\n"); + LOGP(DLMGCP, LOGL_ERROR, "cannot bind OSMUX socket to %s:%u\n", + cfg->osmux_addr, cfg->osmux_port); return ret; } mgcp_set_ip_tos(osmux_fd.fd, cfg->endp_dscp); @@ -525,11 +527,15 @@ ret = osmo_fd_register(&osmux_fd); if (ret < 0) { - LOGP(DLMGCP, LOGL_ERROR, "cannot register OSMUX socket\n"); + LOGP(DLMGCP, LOGL_ERROR, "cannot register OSMUX socket %s\n", + osmo_sock_get_name2(osmux_fd.fd)); return ret; } cfg->osmux_init = 1; + LOGP(DLMGCP, LOGL_INFO, "OSMUX socket listening on %s\n", + osmo_sock_get_name2(osmux_fd.fd)); + return 0; } -- To view, visit https://gerrit.osmocom.org/13883 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I43a658b19765b1c3b3cc42f78602b793ee36c67d Gerrit-Change-Number: 13883 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190506/19c8a5ab/attachment.htm>