<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13883">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmux: Log osmux socket during osmux_init<br><br>Change-Id: I43a658b19765b1c3b3cc42f78602b793ee36c67d<br>---<br>M src/libosmo-mgcp/mgcp_osmux.c<br>1 file changed, 8 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>index 7e26d7a..ce89df1 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>@@ -15,6 +15,7 @@</span><br><span> #include <inttypes.h> /* for PRIu64 */</span><br><span> #include <netinet/in.h></span><br><span> #include <osmocom/core/msgb.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/socket.h></span><br><span> #include <osmocom/core/talloc.h></span><br><span> </span><br><span> #include <osmocom/netif/osmux.h></span><br><span>@@ -517,7 +518,8 @@</span><br><span> </span><br><span>    ret = mgcp_create_bind(cfg->osmux_addr, &osmux_fd, cfg->osmux_port);</span><br><span>       if (ret < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DLMGCP, LOGL_ERROR, "cannot bind OSMUX socket\n");</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGP(DLMGCP, LOGL_ERROR, "cannot bind OSMUX socket to %s:%u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  cfg->osmux_addr, cfg->osmux_port);</span><br><span>                return ret;</span><br><span>  }</span><br><span>    mgcp_set_ip_tos(osmux_fd.fd, cfg->endp_dscp);</span><br><span>@@ -525,11 +527,15 @@</span><br><span> </span><br><span>         ret = osmo_fd_register(&osmux_fd);</span><br><span>       if (ret < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DLMGCP, LOGL_ERROR, "cannot register OSMUX socket\n");</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGP(DLMGCP, LOGL_ERROR, "cannot register OSMUX socket %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                    osmo_sock_get_name2(osmux_fd.fd));</span><br><span>              return ret;</span><br><span>  }</span><br><span>    cfg->osmux_init = 1;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   LOGP(DLMGCP, LOGL_INFO, "OSMUX socket listening on %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+            osmo_sock_get_name2(osmux_fd.fd));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13883">change 13883</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13883"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I43a658b19765b1c3b3cc42f78602b793ee36c67d </div>
<div style="display:none"> Gerrit-Change-Number: 13883 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>