This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vasil Velichkov gerrit-no-reply at lists.osmocom.orgHello Piotr Krysik, Vadim Yanitskiy, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/13246 to review the following change. Change subject: Fix the TCH/H decoder XML definition ...................................................................... Fix the TCH/H decoder XML definition The second argument of tch_h_decoder constructor is a string that accepts the value of MultiRate configuration element and not an enum like the tch_f_decoder decoder. Change-Id: I92d4f49955c634df7d76f17cfb58d7106846c1bd --- M grc/decoding/gsm_tch_h_decoder.xml 1 file changed, 9 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/46/13246/1 diff --git a/grc/decoding/gsm_tch_h_decoder.xml b/grc/decoding/gsm_tch_h_decoder.xml index 895104e..cd7d9cd 100644 --- a/grc/decoding/gsm_tch_h_decoder.xml +++ b/grc/decoding/gsm_tch_h_decoder.xml @@ -3,7 +3,7 @@ <name>TCH/H decoder</name> <key>gsm_tch_h_decoder</key> <import>import grgsm</import> - <make>grgsm.tch_h_decoder($sub_channel, $mode, $boundary_check)</make> + <make>grgsm.tch_h_decoder($sub_channel, $multi_rate, $boundary_check)</make> <param> <name>sub-channel number</name> @@ -20,37 +20,9 @@ </option> </param> <param> - <name>TCH/H coding mode</name> - <key>mode</key> - <type>enum</type> - <option> - <name>GSM-HS</name> - <key>grgsm.TCH_HS</key> - </option> - <option> - <name>GSM-AMR 7.95</name> - <key>grgsm.TCH_AHS7_95</key> - </option> - <option> - <name>GSM-AMR 7.4</name> - <key>grgsm.TCH_AHS7_4</key> - </option> - <option> - <name>GSM-AMR 6.7</name> - <key>grgsm.TCH_AHS6_7</key> - </option> - <option> - <name>GSM-AMR 5.9</name> - <key>grgsm.TCH_AHS5_9</key> - </option> - <option> - <name>GSM-AMR 5.15</name> - <key>grgsm.TCH_AHS5_15</key> - </option> - <option> - <name>GSM-AMR 4.75</name> - <key>grgsm.TCH_AHS4_75</key> - </option> + <name>MultiRrate configuration</name> + <key>multi_rate</key> + <type>string</type> </param> <param> <name>Voice boundary detection</name> @@ -83,6 +55,11 @@ </source> <doc> +The MultiRrate configuration string should contains the hex string from the +MultiRrate configuration element from the Assignment Command message. +Example: 28111a40. +See 3GPP TS 44.018 - 10.5.2.21aa MultiRate configuratio + If "Voice boundary detection" is enabled, then only bursts are decoded as voice where - the framenumber is greater then the framenumber of a received "Connect" or "Connect Acknowlegde" message, and -- To view, visit https://gerrit.osmocom.org/13246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I92d4f49955c634df7d76f17cfb58d7106846c1bd Gerrit-Change-Number: 13246 Gerrit-PatchSet: 1 Gerrit-Owner: Vasil Velichkov <vvvelichkov at gmail.com> Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/b57ec8fc/attachment.htm>