<p>Vasil Velichkov would like Piotr Krysik and Vadim Yanitskiy to <strong>review</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13246">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix the TCH/H decoder XML definition<br><br>The second argument of tch_h_decoder constructor is a string that<br>accepts the value of MultiRate configuration element and not an enum<br>like the tch_f_decoder decoder.<br><br>Change-Id: I92d4f49955c634df7d76f17cfb58d7106846c1bd<br>---<br>M grc/decoding/gsm_tch_h_decoder.xml<br>1 file changed, 9 insertions(+), 32 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/46/13246/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/grc/decoding/gsm_tch_h_decoder.xml b/grc/decoding/gsm_tch_h_decoder.xml</span><br><span>index 895104e..cd7d9cd 100644</span><br><span>--- a/grc/decoding/gsm_tch_h_decoder.xml</span><br><span>+++ b/grc/decoding/gsm_tch_h_decoder.xml</span><br><span>@@ -3,7 +3,7 @@</span><br><span> <name>TCH/H decoder</name></span><br><span> <key>gsm_tch_h_decoder</key></span><br><span> <import>import grgsm</import></span><br><span style="color: hsl(0, 100%, 40%);">- <make>grgsm.tch_h_decoder($sub_channel, $mode, $boundary_check)</make></span><br><span style="color: hsl(120, 100%, 40%);">+ <make>grgsm.tch_h_decoder($sub_channel, $multi_rate, $boundary_check)</make></span><br><span> </span><br><span> <param></span><br><span> <name>sub-channel number</name></span><br><span>@@ -20,37 +20,9 @@</span><br><span> </option></span><br><span> </param></span><br><span> <param></span><br><span style="color: hsl(0, 100%, 40%);">- <name>TCH/H coding mode</name></span><br><span style="color: hsl(0, 100%, 40%);">- <key>mode</key></span><br><span style="color: hsl(0, 100%, 40%);">- <type>enum</type></span><br><span style="color: hsl(0, 100%, 40%);">- <option></span><br><span style="color: hsl(0, 100%, 40%);">- <name>GSM-HS</name></span><br><span style="color: hsl(0, 100%, 40%);">- <key>grgsm.TCH_HS</key></span><br><span style="color: hsl(0, 100%, 40%);">- </option></span><br><span style="color: hsl(0, 100%, 40%);">- <option></span><br><span style="color: hsl(0, 100%, 40%);">- <name>GSM-AMR 7.95</name></span><br><span style="color: hsl(0, 100%, 40%);">- <key>grgsm.TCH_AHS7_95</key></span><br><span style="color: hsl(0, 100%, 40%);">- </option></span><br><span style="color: hsl(0, 100%, 40%);">- <option></span><br><span style="color: hsl(0, 100%, 40%);">- <name>GSM-AMR 7.4</name></span><br><span style="color: hsl(0, 100%, 40%);">- <key>grgsm.TCH_AHS7_4</key></span><br><span style="color: hsl(0, 100%, 40%);">- </option></span><br><span style="color: hsl(0, 100%, 40%);">- <option></span><br><span style="color: hsl(0, 100%, 40%);">- <name>GSM-AMR 6.7</name></span><br><span style="color: hsl(0, 100%, 40%);">- <key>grgsm.TCH_AHS6_7</key></span><br><span style="color: hsl(0, 100%, 40%);">- </option></span><br><span style="color: hsl(0, 100%, 40%);">- <option></span><br><span style="color: hsl(0, 100%, 40%);">- <name>GSM-AMR 5.9</name></span><br><span style="color: hsl(0, 100%, 40%);">- <key>grgsm.TCH_AHS5_9</key></span><br><span style="color: hsl(0, 100%, 40%);">- </option></span><br><span style="color: hsl(0, 100%, 40%);">- <option></span><br><span style="color: hsl(0, 100%, 40%);">- <name>GSM-AMR 5.15</name></span><br><span style="color: hsl(0, 100%, 40%);">- <key>grgsm.TCH_AHS5_15</key></span><br><span style="color: hsl(0, 100%, 40%);">- </option></span><br><span style="color: hsl(0, 100%, 40%);">- <option></span><br><span style="color: hsl(0, 100%, 40%);">- <name>GSM-AMR 4.75</name></span><br><span style="color: hsl(0, 100%, 40%);">- <key>grgsm.TCH_AHS4_75</key></span><br><span style="color: hsl(0, 100%, 40%);">- </option></span><br><span style="color: hsl(120, 100%, 40%);">+ <name>MultiRrate configuration</name></span><br><span style="color: hsl(120, 100%, 40%);">+ <key>multi_rate</key></span><br><span style="color: hsl(120, 100%, 40%);">+ <type>string</type></span><br><span> </param></span><br><span> <param></span><br><span> <name>Voice boundary detection</name></span><br><span>@@ -83,6 +55,11 @@</span><br><span> </source></span><br><span> </span><br><span> <doc></span><br><span style="color: hsl(120, 100%, 40%);">+The MultiRrate configuration string should contains the hex string from the</span><br><span style="color: hsl(120, 100%, 40%);">+MultiRrate configuration element from the Assignment Command message.</span><br><span style="color: hsl(120, 100%, 40%);">+Example: 28111a40.</span><br><span style="color: hsl(120, 100%, 40%);">+See 3GPP TS 44.018 - 10.5.2.21aa MultiRate configuratio</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> If "Voice boundary detection" is enabled, then only bursts are decoded as voice where</span><br><span> </span><br><span> - the framenumber is greater then the framenumber of a received "Connect" or "Connect Acknowlegde" message, and</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13246">change 13246</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13246"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: gr-gsm </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I92d4f49955c634df7d76f17cfb58d7106846c1bd </div>
<div style="display:none"> Gerrit-Change-Number: 13246 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vasil Velichkov <vvvelichkov@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Piotr Krysik <ptrkrysik@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>