Change in ...osmo-bts[master]: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 21 10:26:22 UTC 2019


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14877


Change subject: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode()
......................................................................

scheduler_trx: Handle negative return of gsm0503_tch_hr_decode()

If gsm0503_tch_hr_decode() returns a negative error, we shouldn't
set the marker bit or pass the negative value as length value into
osmo_hr_check_sid().

Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66
Closes: CID#187645
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/77/14877/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 22399c1..e18fcdc 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1327,7 +1327,7 @@
 		 */
 		rc = gsm0503_tch_hr_decode(tch_data, *bursts_p,
 			fn_is_odd, &n_errors, &n_bits_total);
-		if (rc) /* DTXu */
+		if (rc >= 0) /* DTXu */
 			lchan_set_marker(osmo_hr_check_sid(tch_data, rc), lchan);
 		break;
 	case GSM48_CMODE_SPEECH_AMR: /* AMR */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14877
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66
Gerrit-Change-Number: 14877
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/53223bae/attachment.htm>


More information about the gerrit-log mailing list