<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/14877">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">scheduler_trx: Handle negative return of gsm0503_tch_hr_decode()<br><br>If gsm0503_tch_hr_decode() returns a negative error, we shouldn't<br>set the marker bit or pass the negative value as length value into<br>osmo_hr_check_sid().<br><br>Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66<br>Closes: CID#187645<br>---<br>M src/osmo-bts-trx/scheduler_trx.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/77/14877/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>index 22399c1..e18fcdc 100644</span><br><span>--- a/src/osmo-bts-trx/scheduler_trx.c</span><br><span>+++ b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>@@ -1327,7 +1327,7 @@</span><br><span>               */</span><br><span>          rc = gsm0503_tch_hr_decode(tch_data, *bursts_p,</span><br><span>                      fn_is_odd, &n_errors, &n_bits_total);</span><br><span style="color: hsl(0, 100%, 40%);">-           if (rc) /* DTXu */</span><br><span style="color: hsl(120, 100%, 40%);">+            if (rc >= 0) /* DTXu */</span><br><span>                   lchan_set_marker(osmo_hr_check_sid(tch_data, rc), lchan);</span><br><span>            break;</span><br><span>       case GSM48_CMODE_SPEECH_AMR: /* AMR */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/14877">change 14877</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/14877"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66 </div>
<div style="display:none"> Gerrit-Change-Number: 14877 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>