This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12622 ) Change subject: lchan_select: dont allow half rate EFR to be selected ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c@140 PS1, Line 140: There is no full-rate EFR specified! This comment looks confusing. Let's rather say: /* EFR works over FR channels only */ https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c@143 PS1, Line 143: case GSM48_CMODE_SPEECH_V1: Please add some "fall-through" comment here to suppress Coverity / compiler warnings. -- To view, visit https://gerrit.osmocom.org/12622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I961d9aaba81424053ab1dc04ce7799e716af4cd8 Gerrit-Change-Number: 12622 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 18 Jan 2019 05:23:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190118/3e57e8dd/attachment.htm>