<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/12622">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c">File src/osmo-bsc/lchan_select.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c@140">Patch Set #1, Line 140:</a> <code style="font-family:monospace,monospace">There is no full-rate EFR specified!</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This comment looks confusing. Let's rather say:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  /* EFR works over FR channels only */</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12622/1/src/osmo-bsc/lchan_select.c@143">Patch Set #1, Line 143:</a> <code style="font-family:monospace,monospace">      case GSM48_CMODE_SPEECH_V1:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please add some "fall-through" comment here to suppress Coverity / compiler warnings.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12622">change 12622</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12622"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I961d9aaba81424053ab1dc04ce7799e716af4cd8 </div>
<div style="display:none"> Gerrit-Change-Number: 12622 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 18 Jan 2019 05:23:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>