Change in osmo-msc[master]: Don't send Alert Notifications to ESME not bound for RX

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Thu Jan 17 00:09:28 UTC 2019


Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/12599


Change subject: Don't send Alert Notifications to ESME not bound for RX
......................................................................

Don't send Alert Notifications to ESME not bound for RX

Change-Id: Iec92d4c145ca050c2e212139572eeaae581b99df
---
M src/libmsc/smpp_openbsc.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/99/12599/1

diff --git a/src/libmsc/smpp_openbsc.c b/src/libmsc/smpp_openbsc.c
index fb9b0f8..6b7ecbc 100644
--- a/src/libmsc/smpp_openbsc.c
+++ b/src/libmsc/smpp_openbsc.c
@@ -284,6 +284,12 @@
 		/* we currently send an alert notification to each ESME that is
 		 * connected, and do not require a (non-existant) delivery
 		 * pending flag to be set before. */
+		if (!(esme->bind_flags & ESME_BIND_RX)) {
+			LOGP(DSMPP, LOGL_INFO,
+				"[%s] is not bound for RX, skipping alert\n",
+					esme->system_id);
+			continue;
+		}
 		if (!esme->acl->alert_notifications) {
 			LOGP(DSMPP, LOGL_DEBUG,
 				"[%s] is not set to receive Alert Notifications\n",

-- 
To view, visit https://gerrit.osmocom.org/12599
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec92d4c145ca050c2e212139572eeaae581b99df
Gerrit-Change-Number: 12599
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190117/957a7931/attachment.htm>


More information about the gerrit-log mailing list