<p>Keith Whyte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12599">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Don't send Alert Notifications to ESME not bound for RX<br><br>Change-Id: Iec92d4c145ca050c2e212139572eeaae581b99df<br>---<br>M src/libmsc/smpp_openbsc.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/99/12599/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/smpp_openbsc.c b/src/libmsc/smpp_openbsc.c</span><br><span>index fb9b0f8..6b7ecbc 100644</span><br><span>--- a/src/libmsc/smpp_openbsc.c</span><br><span>+++ b/src/libmsc/smpp_openbsc.c</span><br><span>@@ -284,6 +284,12 @@</span><br><span>             /* we currently send an alert notification to each ESME that is</span><br><span>               * connected, and do not require a (non-existant) delivery</span><br><span>            * pending flag to be set before. */</span><br><span style="color: hsl(120, 100%, 40%);">+          if (!(esme->bind_flags & ESME_BIND_RX)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGP(DSMPP, LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+                                "[%s] is not bound for RX, skipping alert\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                       esme->system_id);</span><br><span style="color: hsl(120, 100%, 40%);">+                  continue;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>            if (!esme->acl->alert_notifications) {</span><br><span>                         LOGP(DSMPP, LOGL_DEBUG,</span><br><span>                              "[%s] is not set to receive Alert Notifications\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12599">change 12599</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12599"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iec92d4c145ca050c2e212139572eeaae581b99df </div>
<div style="display:none"> Gerrit-Change-Number: 12599 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>