Change in osmocom-bb[master]: trx_toolkit/burst_fwd.py: fix trx_list cross-reference

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun Jan 13 09:26:51 UTC 2019


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12540


Change subject: trx_toolkit/burst_fwd.py: fix trx_list cross-reference
......................................................................

trx_toolkit/burst_fwd.py: fix trx_list cross-reference

It was discovered that using an empty list as default argument
value does result into the cross-reference, i.e. all instances
of BurstForwarder would reference the same trx_list object.

This is not an expected behaviour, let's fix this.

Change-Id: Id71185de05b0ebc5adb105b10fad2cbde5f800b1
---
M src/target/trx_toolkit/burst_fwd.py
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/12540/1

diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py
index 38ce18f..164271f 100644
--- a/src/target/trx_toolkit/burst_fwd.py
+++ b/src/target/trx_toolkit/burst_fwd.py
@@ -43,9 +43,12 @@
 
 	"""
 
-	def __init__(self, trx_list = []):
+	def __init__(self, trx_list = None):
 		# List of Transceiver instances
-		self.trx_list = trx_list
+		if trx_list is not None:
+			self.trx_list = trx_list
+		else:
+			self.trx_list = []
 
 	def add_trx(self, trx):
 		if trx in self.trx_list:

-- 
To view, visit https://gerrit.osmocom.org/12540
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id71185de05b0ebc5adb105b10fad2cbde5f800b1
Gerrit-Change-Number: 12540
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190113/69803848/attachment.htm>


More information about the gerrit-log mailing list