<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12540">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/burst_fwd.py: fix trx_list cross-reference<br><br>It was discovered that using an empty list as default argument<br>value does result into the cross-reference, i.e. all instances<br>of BurstForwarder would reference the same trx_list object.<br><br>This is not an expected behaviour, let's fix this.<br><br>Change-Id: Id71185de05b0ebc5adb105b10fad2cbde5f800b1<br>---<br>M src/target/trx_toolkit/burst_fwd.py<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/12540/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py</span><br><span>index 38ce18f..164271f 100644</span><br><span>--- a/src/target/trx_toolkit/burst_fwd.py</span><br><span>+++ b/src/target/trx_toolkit/burst_fwd.py</span><br><span>@@ -43,9 +43,12 @@</span><br><span> </span><br><span>       """</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  def __init__(self, trx_list = []):</span><br><span style="color: hsl(120, 100%, 40%);">+    def __init__(self, trx_list = None):</span><br><span>                 # List of Transceiver instances</span><br><span style="color: hsl(0, 100%, 40%);">-         self.trx_list = trx_list</span><br><span style="color: hsl(120, 100%, 40%);">+              if trx_list is not None:</span><br><span style="color: hsl(120, 100%, 40%);">+                      self.trx_list = trx_list</span><br><span style="color: hsl(120, 100%, 40%);">+              else:</span><br><span style="color: hsl(120, 100%, 40%);">+                 self.trx_list = []</span><br><span> </span><br><span>       def add_trx(self, trx):</span><br><span>              if trx in self.trx_list:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12540">change 12540</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12540"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id71185de05b0ebc5adb105b10fad2cbde5f800b1 </div>
<div style="display:none"> Gerrit-Change-Number: 12540 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>