Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12470 )

Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@343
PS2, Line 343: 		 "C
> (one of the reasons why this space-alignment sucks) […]
yeah, my opinion used to be "align with opening brace" for a long time. My opinion is changing now.
Haven't gathered the guts yet to switch my vim rules to "always indent with a single tab"...
your feedback is actually tipping the balance as we speak.

Hmm, can't seem to find the cinoptions item that allows to do this. All I can find is constant indenting after line breaks directly after the opening brace, which I never use:

                cino=(0                    cino=(0,W4
                  a_long_line(              a_long_line(
                              argument,         argument,
                              argument);        argument);
                  a_short_line(argument,    a_short_line(argument,
                               argument);                argument);

I'll switch to single-tab as soon as I find a vim cinoptions rule that does this:

                  a_short_line(argument,
                          argument);



-- 
To view, visit https://gerrit.osmocom.org/12470
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a7809840428b1e028df6eb683bc5ffcc8df474a
Gerrit-Change-Number: 12470
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Jan 2019 01:10:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190111/7ea626fe/attachment.htm>