<p><a href="https://gerrit.osmocom.org/12470">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c">File src/libmsc/gsm_04_08.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12470/2/src/libmsc/gsm_04_08.c@343">Patch Set #2, Line 343:</a> <code style="font-family:monospace,monospace"> "C</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">(one of the reasons why this space-alignment sucks) […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">yeah, my opinion used to be "align with opening brace" for a long time. My opinion is changing now.<br>Haven't gathered the guts yet to switch my vim rules to "always indent with a single tab"...<br>your feedback is actually tipping the balance as we speak.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Hmm, can't seem to find the cinoptions item that allows to do this. All I can find is constant indenting after line breaks directly after the opening brace, which I never use:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> cino=(0 cino=(0,W4<br> a_long_line( a_long_line(<br> argument, argument,<br> argument); argument);<br> a_short_line(argument, a_short_line(argument,<br> argument); argument);</pre><p style="white-space: pre-wrap; word-wrap: break-word;">I'll switch to single-tab as soon as I find a vim cinoptions rule that does this:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> a_short_line(argument,<br> argument);</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12470">change 12470</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12470"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0a7809840428b1e028df6eb683bc5ffcc8df474a </div>
<div style="display:none"> Gerrit-Change-Number: 12470 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 11 Jan 2019 01:10:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>