Change in osmo-ttcn3-hacks[master]: Log all RA values which cause test failure

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13044 )

Change subject: Log all RA values which cause test failure
......................................................................

Log all RA values which cause test failure

Previously the first timeout in TC_rach_content() caused test to
fail. Related TC_rach_count() test shows that there're some (13-16 out
of 1000) RA values which are problematic. Let's log all such values in
TC_rach_content() before failing the test to, hopefully, spot the
pattern which sets such RA values apart.

Change-Id: Ibfeb377101f406608c0193f08729c0e6d084281e
Related: OS#1854
---
M bts/BTS_Tests.ttcn
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Daniel Willmann: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Harald Welte: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 66bf040..279b437 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -996,6 +996,7 @@
 	f_l1_tune(L1CTL);
 
 	var GsmFrameNumber fn_last := 0;
+	var boolean test_failed := false;
 	for (var integer i := 0; i < 1000; i := i+1) {
 		var OCT1 ra := f_rnd_ra_cs();
 		var GsmFrameNumber fn := f_L1CTL_RACH(L1CTL, oct2int(ra));
@@ -1015,11 +1016,14 @@
 			}
 		[] RSL_CCHAN.receive { repeat; }
 		[] T.timeout {
-			Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Timeout waiting for CHAN RQD FN=", fn, " RA=", ra));
+			test_failed := true;
+			log("[", i, "] Timeout waiting for CHAN RQD FN=", fn, " RA=", ra);
 			}
 		}
 	}
-	setverdict(pass);
+	if (test_failed == false) {
+		setverdict(pass);
+	}
 	Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/13044
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfeb377101f406608c0193f08729c0e6d084281e
Gerrit-Change-Number: 13044
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190226/a3e22ffb/attachment.htm>