<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13044">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Daniel Willmann: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Log all RA values which cause test failure<br><br>Previously the first timeout in TC_rach_content() caused test to<br>fail. Related TC_rach_count() test shows that there're some (13-16 out<br>of 1000) RA values which are problematic. Let's log all such values in<br>TC_rach_content() before failing the test to, hopefully, spot the<br>pattern which sets such RA values apart.<br><br>Change-Id: Ibfeb377101f406608c0193f08729c0e6d084281e<br>Related: OS#1854<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 66bf040..279b437 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -996,6 +996,7 @@</span><br><span> f_l1_tune(L1CTL);</span><br><span> </span><br><span> var GsmFrameNumber fn_last := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ var boolean test_failed := false;</span><br><span> for (var integer i := 0; i < 1000; i := i+1) {</span><br><span> var OCT1 ra := f_rnd_ra_cs();</span><br><span> var GsmFrameNumber fn := f_L1CTL_RACH(L1CTL, oct2int(ra));</span><br><span>@@ -1015,11 +1016,14 @@</span><br><span> }</span><br><span> [] RSL_CCHAN.receive { repeat; }</span><br><span> [] T.timeout {</span><br><span style="color: hsl(0, 100%, 40%);">- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Timeout waiting for CHAN RQD FN=", fn, " RA=", ra));</span><br><span style="color: hsl(120, 100%, 40%);">+ test_failed := true;</span><br><span style="color: hsl(120, 100%, 40%);">+ log("[", i, "] Timeout waiting for CHAN RQD FN=", fn, " RA=", ra);</span><br><span> }</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (test_failed == false) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13044">change 13044</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13044"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ibfeb377101f406608c0193f08729c0e6d084281e </div>
<div style="display:none"> Gerrit-Change-Number: 13044 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Willmann <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>