Change in osmo-pcu[master]: Use Timing Advance Index in UL assignments

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12956


Change subject: Use Timing Advance Index in UL assignments
......................................................................

Use Timing Advance Index in UL assignments

Write TAI (if available) when generating Rest Octets for UL
Assignment. This should not affect actual PCU behavior because TAI is
not yet supported by upper layers but we have to adjust corresponding
tests anyway.

That's updated version of reverted commit.

Change-Id: I69407793bdb863be5fc42adadf75842d22f27335
Related: OS#3014
---
M src/encoding.cpp
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/56/12956/1

diff --git a/src/encoding.cpp b/src/encoding.cpp
index 927defd..8b9d4b8 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -255,7 +255,9 @@
 		rc = write_alpha_gamma(dest, alpha, gamma);
 		check(rc);
 
-		set_0(dest); /* No TIMING_ADVANCE_INDEX */
+		rc = write_ta_index(dest, ta_idx);
+		check(rc);
+
 		set_0(dest); /* No TBF_STARTING_TIME */
 	} else {
 		set_0(dest); /* Single Block Allocation */
@@ -317,7 +319,9 @@
 		rc = write_alpha_gamma(dest, alpha, gamma);                 /* ALPHA and GAMMA */
 		check(rc);
 
-		set_0(dest);                                                /* No TIMING_ADVANCE_INDEX */
+		rc = write_ta_index(dest, ta_idx);
+		check(rc);
+
 		set_0(dest);                                                /* No TBF_STARTING_TIME */
 		bitvec_set_bit(dest, L);                                    /* No Additions for Rel-7 */
 	} else {

-- 
To view, visit https://gerrit.osmocom.org/12956
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69407793bdb863be5fc42adadf75842d22f27335
Gerrit-Change-Number: 12956
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190219/67af54ee/attachment.htm>