<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12956">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use Timing Advance Index in UL assignments<br><br>Write TAI (if available) when generating Rest Octets for UL<br>Assignment. This should not affect actual PCU behavior because TAI is<br>not yet supported by upper layers but we have to adjust corresponding<br>tests anyway.<br><br>That's updated version of reverted commit.<br><br>Change-Id: I69407793bdb863be5fc42adadf75842d22f27335<br>Related: OS#3014<br>---<br>M src/encoding.cpp<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/56/12956/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index 927defd..8b9d4b8 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -255,7 +255,9 @@</span><br><span>            rc = write_alpha_gamma(dest, alpha, gamma);</span><br><span>          check(rc);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          set_0(dest); /* No TIMING_ADVANCE_INDEX */</span><br><span style="color: hsl(120, 100%, 40%);">+            rc = write_ta_index(dest, ta_idx);</span><br><span style="color: hsl(120, 100%, 40%);">+            check(rc);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                 set_0(dest); /* No TBF_STARTING_TIME */</span><br><span>      } else {</span><br><span>             set_0(dest); /* Single Block Allocation */</span><br><span>@@ -317,7 +319,9 @@</span><br><span>             rc = write_alpha_gamma(dest, alpha, gamma);                 /* ALPHA and GAMMA */</span><br><span>            check(rc);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          set_0(dest);                                                /* No TIMING_ADVANCE_INDEX */</span><br><span style="color: hsl(120, 100%, 40%);">+             rc = write_ta_index(dest, ta_idx);</span><br><span style="color: hsl(120, 100%, 40%);">+            check(rc);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                 set_0(dest);                                                /* No TBF_STARTING_TIME */</span><br><span>               bitvec_set_bit(dest, L);                                    /* No Additions for Rel-7 */</span><br><span>     } else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12956">change 12956</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12956"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I69407793bdb863be5fc42adadf75842d22f27335 </div>
<div style="display:none"> Gerrit-Change-Number: 12956 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>