Change in osmo-bts[master]: OML: remove double-logging on oml_tx_failure_event_rep()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12866 )

Change subject: OML: remove double-logging on oml_tx_failure_event_rep()
......................................................................

OML: remove double-logging on oml_tx_failure_event_rep()

When we send an OML failure event report using
oml_tx_failure_event_rep(), the function itself will not only send
the report to the BSC but also log it.  So there's no need to both
have an explicit LOGP() and a call to oml_tx_failure_event_rep().

Change-Id: Ib3fd06b3266d896aebeed4ebe42ac71ff173bb5c
---
M src/common/oml.c
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/common/oml.c b/src/common/oml.c
index 6d8bc4b..82d12c7 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -558,7 +558,6 @@
 	}
 
 	if (!TLVP_PRES_LEN(&tp, NM_ATT_LIST_REQ_ATTR, 1)) {
-		LOGP(DOML, LOGL_ERROR, "O&M Get Attributes message without Attribute List?!\n");
 		oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_MAJ_UNSUP_ATTR, "Get Attribute without Attribute List");
 		return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT);
 	}
@@ -1074,9 +1073,6 @@
 		"Unexpected BTS %d in manufacturer O&M %s (exp. 0 or 0xFF)";
 
 	if (foh->obj_inst.bts_nr != 0 && foh->obj_inst.bts_nr != 0xff) {
-		LOGP(DOML, LOGL_ERROR, form, foh->obj_inst.bts_nr, get_value_string(abis_nm_msgtype_names,
-										    foh->msg_type));
-		LOGPC(DOML, LOGL_ERROR, "\n");
 		trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);
 		if (trx)
 			mo = &trx->mo;
@@ -1139,8 +1135,6 @@
 		ret = oml_rx_get_attr(bts, msg);
 		break;
 	default:
-		LOGP(DOML, LOGL_INFO, "unknown Formatted O&M msg_type 0x%02x\n",
-			foh->msg_type);
 		trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);
 		if (trx) {
 			oml_tx_failure_event_rep(&trx->mo, OSMO_EVT_MAJ_UKWN_MSG,

-- 
To view, visit https://gerrit.osmocom.org/12866
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3fd06b3266d896aebeed4ebe42ac71ff173bb5c
Gerrit-Change-Number: 12866
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190210/1aac08b0/attachment.htm>