<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12866">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Pau Espin Pedrol: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">OML: remove double-logging on oml_tx_failure_event_rep()<br><br>When we send an OML failure event report using<br>oml_tx_failure_event_rep(), the function itself will not only send<br>the report to the BSC but also log it. So there's no need to both<br>have an explicit LOGP() and a call to oml_tx_failure_event_rep().<br><br>Change-Id: Ib3fd06b3266d896aebeed4ebe42ac71ff173bb5c<br>---<br>M src/common/oml.c<br>1 file changed, 0 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index 6d8bc4b..82d12c7 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -558,7 +558,6 @@</span><br><span> }</span><br><span> </span><br><span> if (!TLVP_PRES_LEN(&tp, NM_ATT_LIST_REQ_ATTR, 1)) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DOML, LOGL_ERROR, "O&M Get Attributes message without Attribute List?!\n");</span><br><span> oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_MAJ_UNSUP_ATTR, "Get Attribute without Attribute List");</span><br><span> return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT);</span><br><span> }</span><br><span>@@ -1074,9 +1073,6 @@</span><br><span> "Unexpected BTS %d in manufacturer O&M %s (exp. 0 or 0xFF)";</span><br><span> </span><br><span> if (foh->obj_inst.bts_nr != 0 && foh->obj_inst.bts_nr != 0xff) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DOML, LOGL_ERROR, form, foh->obj_inst.bts_nr, get_value_string(abis_nm_msgtype_names,</span><br><span style="color: hsl(0, 100%, 40%);">- foh->msg_type));</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DOML, LOGL_ERROR, "\n");</span><br><span> trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);</span><br><span> if (trx)</span><br><span> mo = &trx->mo;</span><br><span>@@ -1139,8 +1135,6 @@</span><br><span> ret = oml_rx_get_attr(bts, msg);</span><br><span> break;</span><br><span> default:</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DOML, LOGL_INFO, "unknown Formatted O&M msg_type 0x%02x\n",</span><br><span style="color: hsl(0, 100%, 40%);">- foh->msg_type);</span><br><span> trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);</span><br><span> if (trx) {</span><br><span> oml_tx_failure_event_rep(&trx->mo, OSMO_EVT_MAJ_UKWN_MSG,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12866">change 12866</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12866"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib3fd06b3266d896aebeed4ebe42ac71ff173bb5c </div>
<div style="display:none"> Gerrit-Change-Number: 12866 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>