Change in osmo-bts[master]: OML: Send Failure Event Report on short OML messages

[Harald Welte]

Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/12872


Change subject: OML: Send Failure Event Report on short OML messages
......................................................................

OML: Send Failure Event Report on short OML messages

It's much more likely to get noticed if it shows up in the Abis
protocol trace and/or the BSC log than some local log at the BTS.

Change-Id: I4a1b64aa35fa7051d9eb190f3f6f5ea0b28bab8f
---
M src/common/oml.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/72/12872/1

diff --git a/src/common/oml.c b/src/common/oml.c
index 2ae5af5..4697086 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1423,7 +1423,8 @@
 	int ret = 0;
 
 	if (msgb_l2len(msg) < sizeof(*oh)) {
-		LOGP(DOML, LOGL_NOTICE, "OML message too short\n");
+		oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_MAJ_UKWN_MSG,
+					 "OML message too short\n");
 		msgb_free(msg);
 		return -EIO;
 	}

-- 
To view, visit https://gerrit.osmocom.org/12872
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a1b64aa35fa7051d9eb190f3f6f5ea0b28bab8f
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190209/97d8a615/attachment.htm>