<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12872">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">OML: Send Failure Event Report on short OML messages<br><br>It's much more likely to get noticed if it shows up in the Abis<br>protocol trace and/or the BSC log than some local log at the BTS.<br><br>Change-Id: I4a1b64aa35fa7051d9eb190f3f6f5ea0b28bab8f<br>---<br>M src/common/oml.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/72/12872/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index 2ae5af5..4697086 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -1423,7 +1423,8 @@</span><br><span>      int ret = 0;</span><br><span> </span><br><span>     if (msgb_l2len(msg) < sizeof(*oh)) {</span><br><span style="color: hsl(0, 100%, 40%);">-         LOGP(DOML, LOGL_NOTICE, "OML message too short\n");</span><br><span style="color: hsl(120, 100%, 40%);">+         oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_MAJ_UKWN_MSG,</span><br><span style="color: hsl(120, 100%, 40%);">+                                       "OML message too short\n");</span><br><span>               msgb_free(msg);</span><br><span>              return -EIO;</span><br><span>         }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12872">change 12872</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12872"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4a1b64aa35fa7051d9eb190f3f6f5ea0b28bab8f </div>
<div style="display:none"> Gerrit-Change-Number: 12872 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>