Change in simtrace2[master]: usb_buf: Actually limit queue to 3 elements, not 4

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Dec 15 16:31:07 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16598 )

Change subject: usb_buf: Actually limit queue to 3 elements, not 4
......................................................................

usb_buf: Actually limit queue to 3 elements, not 4

In Change-ID Ie15183f16b22193ffdaf01845db2eae4c7f43c17 we wanted
to limit the number of queue elements to 3, but actually implemented 4.

Change-Id: Ic5fb164f2dfd1c293c51bee8184fc34552267a54
---
M firmware/libcommon/source/usb_buf.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/firmware/libcommon/source/usb_buf.c b/firmware/libcommon/source/usb_buf.c
index 7892d6e..b6ecd54 100644
--- a/firmware/libcommon/source/usb_buf.c
+++ b/firmware/libcommon/source/usb_buf.c
@@ -80,7 +80,7 @@
 	/* no need for irqsafe operation, as the usb_tx_queue is
 	 * processed only by the main loop context */
 
-	if (ep->queue_len > USB_MAX_QLEN) {
+	if (ep->queue_len >= USB_MAX_QLEN) {
 		struct msgb *evict;
 		/* free the first pending buffer in the queue */
 		TRACE_INFO("EP%02x: dropping first queue element (qlen=%u)\r\n",

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16598
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ic5fb164f2dfd1c293c51bee8184fc34552267a54
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191215/e0866d70/attachment.htm>


More information about the gerrit-log mailing list