<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16598">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">usb_buf: Actually limit queue to 3 elements, not 4<br><br>In Change-ID Ie15183f16b22193ffdaf01845db2eae4c7f43c17 we wanted<br>to limit the number of queue elements to 3, but actually implemented 4.<br><br>Change-Id: Ic5fb164f2dfd1c293c51bee8184fc34552267a54<br>---<br>M firmware/libcommon/source/usb_buf.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/usb_buf.c b/firmware/libcommon/source/usb_buf.c</span><br><span>index 7892d6e..b6ecd54 100644</span><br><span>--- a/firmware/libcommon/source/usb_buf.c</span><br><span>+++ b/firmware/libcommon/source/usb_buf.c</span><br><span>@@ -80,7 +80,7 @@</span><br><span>     /* no need for irqsafe operation, as the usb_tx_queue is</span><br><span>      * processed only by the main loop context */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       if (ep->queue_len > USB_MAX_QLEN) {</span><br><span style="color: hsl(120, 100%, 40%);">+     if (ep->queue_len >= USB_MAX_QLEN) {</span><br><span>           struct msgb *evict;</span><br><span>          /* free the first pending buffer in the queue */</span><br><span>             TRACE_INFO("EP%02x: dropping first queue element (qlen=%u)\r\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16598">change 16598</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16598"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic5fb164f2dfd1c293c51bee8184fc34552267a54 </div>
<div style="display:none"> Gerrit-Change-Number: 16598 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>