Change in simtrace2[master]: card_emu: Remove extraneous code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Dec 15 16:26:02 UTC 2019


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16603 )


Change subject: card_emu: Remove extraneous code
......................................................................

card_emu: Remove extraneous code

card_set_state(ch, ISO_S_WAIT_ATR) internally calls tc_etu_enable(),
so there's no need for the caller to do the same, too.

Change-Id: I2a2b4d64c40264623313a867957ffcefe57748f9
---
M firmware/libcommon/source/card_emu.c
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/03/16603/1

diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c
index 66932af..0577a12 100644
--- a/firmware/libcommon/source/card_emu.c
+++ b/firmware/libcommon/source/card_emu.c
@@ -440,7 +440,7 @@
 		 * since the initial ETU is Fd=372/Dd=1 clock cycles long, we have to wait 2-107 ETU.
 		 */
 		tc_etu_set_wtime(ch->tc_chan, 2);
-		/* ensure the TC_ETU timer is enabled */
+		/* enable the TC/ETU counter once reset has been released */
 		tc_etu_enable(ch->tc_chan);
 		break;
 	case ISO_S_IN_ATR:
@@ -1111,8 +1111,6 @@
 	/* check end activation state (only necessary if the reader to
 	 * not respect the activation sequence) */
 	if (ch->vcc_active && ch->clocked && !ch->in_reset) {
-		/* enable the TC/ETU counter once reset has been released */
-		tc_etu_enable(ch->tc_chan);
 		/* prepare to send the ATR */
 		card_set_state(ch, ISO_S_WAIT_ATR);
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16603
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I2a2b4d64c40264623313a867957ffcefe57748f9
Gerrit-Change-Number: 16603
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191215/2eaa6981/attachment.htm>


More information about the gerrit-log mailing list