<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16603">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">card_emu: Remove extraneous code<br><br>card_set_state(ch, ISO_S_WAIT_ATR) internally calls tc_etu_enable(),<br>so there's no need for the caller to do the same, too.<br><br>Change-Id: I2a2b4d64c40264623313a867957ffcefe57748f9<br>---<br>M firmware/libcommon/source/card_emu.c<br>1 file changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/03/16603/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c</span><br><span>index 66932af..0577a12 100644</span><br><span>--- a/firmware/libcommon/source/card_emu.c</span><br><span>+++ b/firmware/libcommon/source/card_emu.c</span><br><span>@@ -440,7 +440,7 @@</span><br><span>             * since the initial ETU is Fd=372/Dd=1 clock cycles long, we have to wait 2-107 ETU.</span><br><span>                 */</span><br><span>          tc_etu_set_wtime(ch->tc_chan, 2);</span><br><span style="color: hsl(0, 100%, 40%);">-            /* ensure the TC_ETU timer is enabled */</span><br><span style="color: hsl(120, 100%, 40%);">+              /* enable the TC/ETU counter once reset has been released */</span><br><span>                 tc_etu_enable(ch->tc_chan);</span><br><span>               break;</span><br><span>       case ISO_S_IN_ATR:</span><br><span>@@ -1111,8 +1111,6 @@</span><br><span>   /* check end activation state (only necessary if the reader to</span><br><span>        * not respect the activation sequence) */</span><br><span>   if (ch->vcc_active && ch->clocked && !ch->in_reset) {</span><br><span style="color: hsl(0, 100%, 40%);">-          /* enable the TC/ETU counter once reset has been released */</span><br><span style="color: hsl(0, 100%, 40%);">-            tc_etu_enable(ch->tc_chan);</span><br><span>               /* prepare to send the ATR */</span><br><span>                card_set_state(ch, ISO_S_WAIT_ATR);</span><br><span>  }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16603">change 16603</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16603"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2a2b4d64c40264623313a867957ffcefe57748f9 </div>
<div style="display:none"> Gerrit-Change-Number: 16603 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>