Change in osmo-bsc[master]: gsm_04_80: Avoid using deprecated API

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Dec 6 14:04:23 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16476 )

Change subject: gsm_04_80: Avoid using deprecated API
......................................................................

gsm_04_80: Avoid using deprecated API

gsm_04_80_utils.c: In function ‘bsc_send_ussd_release_complete’:
gsm_04_80_utils.c:37:9: warning: ‘gsm0480_create_ussd_release_complete’ is deprecated: Use gsm0480_create_release_complete() instead. [-Wdeprecated-declarations]
   37 |  struct msgb *msg = gsm0480_create_ussd_release_complete();
      |         ^~~~
  CC       gsm_data.o
In file included from gsm_04_80_utils.c:22:
/usr/local/include/osmocom/gsm/gsm0480.h:120:14: note: declared here
  120 | struct msgb *gsm0480_create_ussd_release_complete(void)
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The commit is not changing the existing logic/assumption: TID 0 should
not be in use by anything else at the point the USSD is generated.

Change-Id: I739158dec62cd5f0c2080fbb426af9c024baef87
---
M src/osmo-bsc/gsm_04_80_utils.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/gsm_04_80_utils.c b/src/osmo-bsc/gsm_04_80_utils.c
index 8de1262..5ac0226 100644
--- a/src/osmo-bsc/gsm_04_80_utils.c
+++ b/src/osmo-bsc/gsm_04_80_utils.c
@@ -34,7 +34,8 @@
 
 int bsc_send_ussd_release_complete(struct gsm_subscriber_connection *conn)
 {
-	struct msgb *msg = gsm0480_create_ussd_release_complete();
+	/* ugly: we obviously don't know if TID 0 is currently in user for the given subscriber... */
+	struct msgb *msg = gsm0480_create_release_complete(0);
 	if (!msg)
 		return -1;
 	gscon_submit_rsl_dtap(conn, msg, 0, 0);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/16476
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I739158dec62cd5f0c2080fbb426af9c024baef87
Gerrit-Change-Number: 16476
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191206/12e15b4b/attachment.htm>


More information about the gerrit-log mailing list