<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16476">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_04_80: Avoid using deprecated API<br><br>gsm_04_80_utils.c: In function ‘bsc_send_ussd_release_complete’:<br>gsm_04_80_utils.c:37:9: warning: ‘gsm0480_create_ussd_release_complete’ is deprecated: Use gsm0480_create_release_complete() instead. [-Wdeprecated-declarations]<br>   37 |  struct msgb *msg = gsm0480_create_ussd_release_complete();<br>      |         ^~~~<br>  CC       gsm_data.o<br>In file included from gsm_04_80_utils.c:22:<br>/usr/local/include/osmocom/gsm/gsm0480.h:120:14: note: declared here<br>  120 | struct msgb *gsm0480_create_ussd_release_complete(void)<br>      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br><br>The commit is not changing the existing logic/assumption: TID 0 should<br>not be in use by anything else at the point the USSD is generated.<br><br>Change-Id: I739158dec62cd5f0c2080fbb426af9c024baef87<br>---<br>M src/osmo-bsc/gsm_04_80_utils.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_04_80_utils.c b/src/osmo-bsc/gsm_04_80_utils.c</span><br><span>index 8de1262..5ac0226 100644</span><br><span>--- a/src/osmo-bsc/gsm_04_80_utils.c</span><br><span>+++ b/src/osmo-bsc/gsm_04_80_utils.c</span><br><span>@@ -34,7 +34,8 @@</span><br><span> </span><br><span> int bsc_send_ussd_release_complete(struct gsm_subscriber_connection *conn)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     struct msgb *msg = gsm0480_create_ussd_release_complete();</span><br><span style="color: hsl(120, 100%, 40%);">+    /* ugly: we obviously don't know if TID 0 is currently in user for the given subscriber... */</span><br><span style="color: hsl(120, 100%, 40%);">+     struct msgb *msg = gsm0480_create_release_complete(0);</span><br><span>       if (!msg)</span><br><span>            return -1;</span><br><span>   gscon_submit_rsl_dtap(conn, msg, 0, 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16476">change 16476</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/16476"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I739158dec62cd5f0c2080fbb426af9c024baef87 </div>
<div style="display:none"> Gerrit-Change-Number: 16476 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>