This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgHello osmith, Jenkins Builder, 
I'd like you to reexamine a change. Please visit
    https://gerrit.osmocom.org/c/osmo-bts/+/16440
to look at the new patch set (#2).
Change subject: power_control.c: Clarify loop algo vars and use correct ones during log
......................................................................
power_control.c: Clarify loop algo vars and use correct ones during log
Rename some variables so that:
* Variables containing power control levels end up with "_lvl".
* Variables containing power levels end up with _dbm.
* Move old current_dbm var to be ms_dbm, to match its power control
level counterpart ms_power_lvl, and add current_dbm to match its
counterpart ns_power_ctrl.current.
Now that variables are more clear, it also becomes clear that old "diff >
0" condition, apart from difficult, was currently wrong, since in order
to print the raise/low verb we want to compare between old and new
values, not between received and new values. Let's fix that in this same
commit.
Change-Id: I4e279a6b93fbcc5da25bf8c9213310939fd493ce
---
M src/common/power_control.c
1 file changed, 18 insertions(+), 18 deletions(-)
  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/40/16440/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16440
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4e279a6b93fbcc5da25bf8c9213310939fd493ce
Gerrit-Change-Number: 16440
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191205/f7b79b59/attachment.htm>