This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16440 )
Change subject: power_control.c: Clarify loop algo vars and use correct ones during log
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/osmo-bts/+/16440/1//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/16440/1//COMMIT_MSG@16
PS1, Line 16: Now that variables are more clear, it also becomes clear that old "diff >
: 0" condition, apart from difficult, was currently wrong, since in order
: to print the raise/low verb we want to compare between old and new
: values, not between received and new values.
>From reading this, it was not clear to me, that the condition is fixed with this patch. Looking at the code, it is - so maybe state that explicitly?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16440
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4e279a6b93fbcc5da25bf8c9213310939fd493ce
Gerrit-Change-Number: 16440
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Dec 2019 11:31:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191205/e142d965/attachment.htm>